Open
Conversation
Comment on lines
+4
to
+6
| Adapted from pypdf's own benchmarks: | ||
|
|
||
| https://github.com/py-pdf/pypdf/blob/main/tests/bench.py |
Member
There was a problem hiding this comment.
Assuming it makes sense to do so, could we contribute a change upstream to make their benchmarks compatible with pyperformance (and pull them in like we do for the pyston benchmarks), instead of landing a new benchmark here?
|
|
||
| Rotation, scaling, translation, content stream compression, text extraction | ||
| """ | ||
| content = (DATA_DIR / "libreoffice-writer-password.pdf").read_bytes() |
Member
There was a problem hiding this comment.
FWIW, GitHub says this is an invalid PDF file, though I'm sure it's fine.
Also, it may be worth adding a note about where this file came from and what's in it, especially since it's a binary format.
Contributor
Author
There was a problem hiding this comment.
Yeah, that's a good point. It's a password-protected PDF file, which is probably why Github doesn't like it. I just grabbed what pypdf was using -- we could choose something more deliberately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.